Deploy electricityMap static assets to GCS #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corradio
commented
Dec 26, 2020
| outputs: | ||
| - public/dist/zonegeometries.json | ||
| - src/world.json | ||
| - public/dist |
There was a problem hiding this comment.
brick now also builds the frontend
corradio
commented
Dec 26, 2020
| @@ -1,5 +1,5 @@ | |||
| FROM node:12.13.1 | |||
| WORKDIR /home/web | |||
| WORKDIR /home/src/electricitymap/contrib/web | |||
There was a problem hiding this comment.
in order to keep consistent with brick paths
corradio
commented
Dec 26, 2020
| // Note: `resolvePath` is executed on the client as well, | ||
| // as it is used in react components. We can't therefore include any variables | ||
| // in its closure. It would be better to pass a `pathPrefix` instead. | ||
| resolvePath: (!isProduction || isStaging) |
There was a problem hiding this comment.
this is the important non-lint change to make sure we use GCS in production
corradio
commented
Dec 26, 2020
| @@ -224,7 +222,13 @@ app.use('/', (req, res) => { | |||
| } | |||
| }); | |||
|
|
|||
| if (isProduction) { | |||
| app.get('/*', (req, res) => | |||
There was a problem hiding this comment.
legacy redirect (but shouldn't be necessary)
6 tasks
con-cat
pushed a commit
to con-cat/electricitymap-contrib
that referenced
this pull request
May 18, 2021
* Deploy electricityMap static assets to GCS * update dockerfile paths * Revert * Fix dockerfile * Add config * update container path * No need to clean dir * rename env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal PR to simplify deployment on our side:
Blocked by electricitymaps/brick#74